2.x psr log and php multi compat #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating dependencies to be able to work with newer Psr/Log BREAKING CHANGE: we are dropping support for PHP 7.x and Psr/Log 1.x
Ignore error comming from the different return type on earlier versions of WP In WP < 6.1 the return type was array[]|false
Contributor
|
We can retire this. The entire work has been done for v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #.
What's Included in This Pull Request
Aditional information
Supporting 3 versions of psr/log is making composer incapable to resolve to version 2 in the tests.
I ran PHPUnit tests in my local using nektos/act modifying composer.json to see the results and it passes.
The min version required of monolog has to be 2.0.1 because the BufferHandler does not meet the interface FormattableHandlerInterface see:
Seldaek/monolog@f9d56fd
Let me know your thoughts.